Skip to content

Conversation

@gupadhyaya
Copy link
Contributor

Copies #4549 as previous one is unable to merge due to fork docker issue. No review required, just approvals

- Remove unsupported broadcast control options from bitswap
- Add missing HashOnRead method to BlockstoreWithMetrics
- Enable metrics flags in tastora framework for bridge and light nodes
The HashOnRead method is not part of the current boxo Blockstore interface
- Change nodeImage to use local celestia-node-local image
- Update defaultNodeTag to use our commit 6bc2316 with metrics fixes
The interface check was failing because HashOnRead method was removed from the Blockstore interface
@gupadhyaya gupadhyaya requested a review from Wondertan October 28, 2025 10:18
@gupadhyaya gupadhyaya enabled auto-merge October 28, 2025 10:20
Copy link
Member

@renaynay renaynay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add err as attribute to total counters (so we can filter by successful vs unsuccessful)

@Wondertan Wondertan disabled auto-merge October 28, 2025 10:45
@Wondertan Wondertan enabled auto-merge October 28, 2025 10:45
@gupadhyaya gupadhyaya requested a review from renaynay October 28, 2025 13:01
renaynay
renaynay previously approved these changes Oct 28, 2025
renaynay
renaynay previously approved these changes Oct 28, 2025
@gupadhyaya gupadhyaya requested a review from walldiss October 30, 2025 07:38
Copy link
Member

@renaynay renaynay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utack

@Wondertan Wondertan added this pull request to the merge queue Oct 30, 2025
Merged via the queue into main with commit 1a1b561 Oct 30, 2025
23 of 24 checks passed
@Wondertan Wondertan deleted the blob_submission_metrics branch October 30, 2025 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind:feat Attached to feature PRs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants